-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(user): add list org, merchant and profile api #5662
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racnan
added
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
A-users
Area: Users
labels
Aug 21, 2024
Review changes with SemanticDiff. Analyzed 9 of 9 files. Overall, the semantic diff is 2% smaller than the GitHub diff.
|
Closed
racnan
changed the title
List user roles
feat(user): add list org, merchant and profile api
Aug 21, 2024
jarnura
previously approved these changes
Aug 22, 2024
apoorvdixit88
previously approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⭐
jarnura
approved these changes
Aug 22, 2024
apoorvdixit88
approved these changes
Aug 22, 2024
likhinbopanna
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Aug 22, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
New APIs list:
Additional Changes
Motivation and Context
Need new list apis for dashboard frontend.
This would allow user to see the list of all the orgs, merchant accounts (in select org) & profile ids (in select merchant account).
How did you test it?
List orgs
response example
List merchants
response example
List profile
response example
Checklist
cargo +nightly fmt --all
cargo clippy