Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ci: enable compilation check for v2 features by running check_v2 on merge_group #5804

Merged
merged 5 commits into from
Sep 5, 2024
Merged

ci: enable compilation check for v2 features by running check_v2 on merge_group #5804

merged 5 commits into from
Sep 5, 2024

Conversation

sai-harsha-vardhan
Copy link
Contributor

@sai-harsha-vardhan sai-harsha-vardhan commented Sep 5, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR enables compilation check for v2 features by running check_v2 on merge queue, and runs cargo check with no default features enabling release and v2 features in pr checks

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sai-harsha-vardhan sai-harsha-vardhan added the A-CI-CD Area: Continuous Integration/Deployment label Sep 5, 2024
@sai-harsha-vardhan sai-harsha-vardhan added this to the August 2024 Release milestone Sep 5, 2024
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Sep 5, 2024
@sai-harsha-vardhan sai-harsha-vardhan requested a review from a team as a code owner September 5, 2024 07:28
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@sai-harsha-vardhan sai-harsha-vardhan changed the title ci: run compilation check for v2 features by running check_v2 on merge queue ci: enable compilation check for v2 features by running check_v2 on merge queue Sep 5, 2024
@sai-harsha-vardhan sai-harsha-vardhan changed the title ci: enable compilation check for v2 features by running check_v2 on merge queue ci: enable compilation check for v2 features by running check_v2 on merge_group Sep 5, 2024
@SanchithHegde SanchithHegde added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 4edf2f2 Sep 5, 2024
12 of 14 checks passed
@SanchithHegde SanchithHegde deleted the add-check-v2-in-merge-queue branch September 5, 2024 18:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ShankarSinghC ShankarSinghC ShankarSinghC approved these changes

Assignees

@sai-harsha-vardhan sai-harsha-vardhan

Labels
A-CI-CD Area: Continuous Integration/Deployment api-v2
Projects
None yet
Milestone
August 2024 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@sai-harsha-vardhan @SanchithHegde @ShankarSinghC