-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor(core): add connector mandate id in payments_response
based on merchant config
#5999
Conversation
Review changes with SemanticDiff. Analyzed 8 of 8 files. Overall, the semantic diff is 35% smaller than the GitHub diff.
|
crates/api_models/src/payments.rs
Outdated
@@ -3925,6 +3925,9 @@ pub struct PaymentsResponse { | |||
pub merchant_order_reference_id: Option<String>, | |||
/// order tax amount calculated by tax connectors | |||
pub order_tax_amount: Option<MinorUnit>, | |||
|
|||
/// Identifier for the payment_method saved with the connector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you verify this doc comment
Ok((pm_id, pm_status)) | ||
let cmid_config = db | ||
.find_config_by_key_unwrap_or( | ||
format!("{}_connector_mandate_details", merchant_account.get_id().get_string_repr().to_owned()).as_str(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
config name doesn't convey its purpose
…y/hyperswitch into cmid-under-merchant-config
…y/hyperswitch into cmid-under-merchant-config
Type of Change
Description
Add
connector_mandate_id
as a field inpayments_response
based on merchant level config.Additional Changes
Motivation and Context
How did you test it?
connector_mandate_details
field would be NoneChecklist
cargo +nightly fmt --all
cargo clippy