Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

build(docker-compose-development): address build failure of hyperswitch-server service #6217

Merged
merged 1 commit into from
Oct 7, 2024
Merged

build(docker-compose-development): address build failure of hyperswitch-server service #6217

merged 1 commit into from
Oct 7, 2024

Conversation

akhildevelops
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Fixes: #6216

Builds a docker image with protobuf for hyperswitch-server.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Refer here for the issue Fixes: #6216

How did you test it?

docker compose --file docker-compose-development.yml up -d

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@akhildevelops akhildevelops requested a review from a team as a code owner October 4, 2024 02:40
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

pixincreate
pixincreate approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@pixincreate pixincreate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SanchithHegde SanchithHegde requested a review from lsampras October 4, 2024 07:59
@SanchithHegde SanchithHegde changed the title Builds docker image with protobuf build(docker-compose-development): address build failure of hyperswitch-server service Oct 4, 2024
@SanchithHegde SanchithHegde added C-bug Category: Bug hacktoberfest Issues that are up for grabs for Hacktoberfest participants S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 4, 2024
lcrojano
lcrojano reviewed Oct 5, 2024
View reviewed changes
Copy link

@lcrojano lcrojano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same problem. I have tested this commit in WSL2 Ubuntu 20.4 Windows. It worked as expected

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Oct 7, 2024
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 7, 2024
Merged via the queue into juspay:main with commit b79f75a Oct 7, 2024
20 of 21 checks passed
@akhildevelops akhildevelops deleted the compose-file branch October 7, 2024 16:37
@gorakhnathy7 gorakhnathy7 added the hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions label Oct 31, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lcrojano lcrojano lcrojano left review comments

@pixincreate pixincreate pixincreate approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@lsampras lsampras lsampras approved these changes

Assignees

@akhildevelops akhildevelops

Labels
C-bug Category: Bug hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Docker Compose dev environment fails to setup hyperswitch-server
7 participants
@akhildevelops @lcrojano @lsampras @SanchithHegde @pixincreate @gorakhnathy7 @Gnanasundari24