fix(router): update nick_name only if card_token.card_holder_name is non empty and populate additional card_details from payment_attempt if not present in the locker #6320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… populate additional card_details from payment_attempt if not present in the locker
|
Review changes with SemanticDiff. Analyzed 2 of 2 files. Overall, the semantic diff is 14% smaller than the GitHub diff.
|
Chethan-rao
approved these changes
Oct 15, 2024
sai-harsha-vardhan
added
the
S-waiting-on-review
ShankarSinghC
approved these changes
Oct 15, 2024
SanchithHegde
removed
the
S-waiting-on-review
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Main PR - #6308
Additional Changes
Motivation and Context
How did you test it?
Test cases in main PR
Checklist
cargo +nightly fmt --allcargo clippy