-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(connector): add 3DS flow for Worldpay #6374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n > 128 characters
… update v2_migrations down query
…wallets-api-updates
Review changes with SemanticDiff. Analyzed 8 of 8 files. Overall, the semantic diff is 17% smaller than the GitHub diff.
|
2 tasks
kashif-m
added
A-connector-integration
Area: Connector integration
A-core
Area: Core flows
R-waiting-on-L1
Review: Waiting on L1 reviewer
labels
Oct 20, 2024
jarnura
previously approved these changes
Oct 21, 2024
deepanshu-iiitu
previously approved these changes
Oct 21, 2024
likhinbopanna
dismissed stale reviews from deepanshu-iiitu and jarnura
October 21, 2024 10:24
The base branch was changed.
deepanshu-iiitu
approved these changes
Oct 21, 2024
jarnura
approved these changes
Oct 21, 2024
2 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
A-connector-integration
Area: Connector integration
A-core
Area: Core flows
R-waiting-on-L1
Review: Waiting on L1 reviewer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Described in #6177
Additional Changes
Motivation and Context
Integrates Worldpay's 3DS flow
How did you test it?
Things to test
1. Create and capture
cURL
Response
Open the link and continue
Screen.Recording.2024-10-21.at.4.30.10.PM.mov
2. Create a payment using manual capture
cURL
Response
cURL (capture)
Response
3. Payments Sync
cURL
Response
Checklist
cargo +nightly fmt --all
cargo clippy