fix: config version alter query #444
Conversation
| DROP COLUMN change_reason; |
There was a problem hiding this comment.
@Datron change is correct ,
can we rename migration file from remove_description -> remove_change_reason
| file = "src/superposition_schema.rs" | ||
| patch_file = "schema.patch" | ||
| file = "superposition_schema.rs" | ||
| patch_file = "superposition_schema.patch" |
There was a problem hiding this comment.
why do we have schema.patch file ?
if its not being used ?
There was a problem hiding this comment.
I'm just keeping it consistent incase a diesel migration is run
There was a problem hiding this comment.
ok, but didnt get the flow over here
saw there is a new make command, didn't get it's use-case
| @@ -1,3 +1,3 @@ | |||
| -- Your SQL goes here | |||
| ALTER TABLE public.config_versions | |||
There was a problem hiding this comment.
this query was to be added in workspace_template.sql file as well
db_init.sql was also not updated
There was a problem hiding this comment.
db_init not updated yet
also, in the db_init file, experiment_status_type does not include DISCARDED type for some reason
it was added there, but apparently in some fix PR it got removed, making it incorrect, can you please also include that as well
| @@ -197,3 +197,10 @@ amend-no-edit: COMMIT_FLAGS += --no-edit | |||
| amend-no-edit: amend | |||
|
|
|||
| default: dev-build | |||
|
|
|||
| schema-file: | |||
There was a problem hiding this comment.
should we not add this to .PHONY ? is it returning some usable file ?
Problem
When running diesel migration command, I was getting errors as there was a discrepancy between database schemas and models defined in rust
Solution
Updated the query causing the issue and added a make target that can help setup the schema