Create minifier to identify errors #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
- Coverage 61.08% 59.02% -2.07%
==========================================
Files 22 22
Lines 2850 2987 +137
Branches 610 635 +25
==========================================
+ Hits 1741 1763 +22
- Misses 920 1032 +112
- Partials 189 192 +3 ☔ View full report in Codecov by Sentry. |
|
Fixes #162 |
fatcat-z
reviewed
Aug 22, 2024
| def _compare_tensors( | ||
| expected: torch.Tensor, | ||
| actual: torch.Tensor, | ||
| ) -> tuple[float, float]: | ||
| # Move tensors to the same device | ||
| expected = expected.detach().cpu() | ||
| actual = actual.detach().cpu() | ||
| if expected.dtype == torch.bool: |
There was a problem hiding this comment.
Do we need to compare the dtype to make sure they are equal before we compare their values?
There was a problem hiding this comment.
In theory no because ort would have complained already. But we could check
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the verification module