Problem with Streak-mode target highlighting (not multibyte)

[mon10a]

Streak-mode almost always leaves out the target for me for some of the matches. The targets left out are almost always in the same line/paragraph as the first match.

Also, when the targets are present, they are in no particular order (I can't tell if this is what you intended).

Vim 7.3
Mac OSX
patches 1-390 plus breakindent
Solarized Dark theme
Plugins: EasyMotion, ack, NERDtree, peepopen, sneak, unite, voom

regards,

mon10a

[justinmk]

Thanks for the report. Can you provide sample text that this occurs on? Are there tabs or any other special characters? (It should work just fine with tabs, however)

when the targets are present, they are in no particular order

It should be in the order of the following characters:

asdfghjklqwertyuiopzxcvbnmASDFGHJKLQWERTYUIOPZXCVBNM

This is actually customizable via the g:sneak#target_labels variable, but I haven't documented it yet.

This order was chosen in a (haphazard) attempt to be "home-row friendly".

[justinmk]

patches 1-390 plus breakindent

That seems... significant. Are you able to reproduce in Vim 7.3.390 without that patch?

[mon10a]

Hi, thanks for the fast response. I did not mention it before, but I think
Sneak is great.

I am attaching a screenshot using streak with the search "sth" as well as
the file.

"home-row-friendly" for targets is ok, but for touch typists, alpha order
is probably better

On Thu, Jan 9, 2014 at 1:07 PM, justinmk notifications@github.com wrote:

patches 1-390 plus breakindent

That seems... significant. Are you able to reproduce in Vim 7.3.390
without that patch?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/55#issuecomment-31959620
.

[justinmk]

Glad to hear it! I don't think your attachments came through on github.

"home-row-friendly" for targets is ok, but for touch typists, alpha order is probably better

Alpha order is probaby more predictable. I personally don't care, so I'm open to suggestions for better defaults.

[justinmk]

Also, let me know if you are able to reproduce this issue on Vim without the 'breakindent' patch (which looks really cool btw).

[mon10a]

trying the image file again

[mon10a]

The file is plain text. No tabs either.

[justinmk]

Ha! Yes that's actually exactly a result of the line wrapping. Notice how the unlabeled matches are the ones that would be off screen if the line were not wrapped.

I will have to think about this.

[justinmk]

I just checked, and it turns out this is a bug even with plain old wrap (doesn't require the 'breakindent' patch). I should have a fix in the next day or so. Thanks for reporting!

[justinmk]

@mon10a Does 'breakindent' work even if &wrap=0 ? I'm wondering if I need to check &breakindent or if just checking &wrap is sufficient. Also, does echo has('breakindent') return 1 for you?

[justinmk]

This should be fixed, let me know how it goes. Also still curious about whether 'breakindent' requires 'wrap'.

[mon10a]

I do not believe that breakindent requires wrap, but I will check.

m

On Jan 11, 2014, at 12:37 AM, justinmk notifications@github.com wrote:

This should be fixed, let me know how it goes. Also still curious about whether 'breakindent' requires 'wrap'.

—
Reply to this email directly or view it on GitHub.

[mon10a]

Wow, streak mode really works well now. Thanks for fixing so quickly.

As a prose writer, I think Sneak in streak mode is much more efficient that
EasyMotion.

echo has('breakindent') returns 0

regards

mon10a

On Sat, Jan 11, 2014 at 12:37 AM, justinmk notifications@github.com wrote:

This should be fixed, let me know how it goes. Also still curious about
whether 'breakindent' requires 'wrap'.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/55#issuecomment-32088092
.

[justinmk]

Glad to hear it!

So, echo &wrap returns 1, right?

[mon10a]

Yes, echo &wrap returns 1