Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Doesn't work well when aspect ratio is different from 16:9 #92

Closed
elibarzilay opened this issue Jul 23, 2023 · 0 comments
Closed

Doesn't work well when aspect ratio is different from 16:9 #92

elibarzilay opened this issue Jul 23, 2023 · 0 comments
Milestone
v1.6.0

Comments

@elibarzilay
Copy link
Contributor

I have a page with a few videos that have a weird non-16/9 aspect ratio. The result renders that inside of a 16/9 iframe which makes it look bad. I just blindly grepped the code for 16 / 9 and changed it which looks like it makes it work as intended.
elibarzilay added a commit to elibarzilay/lite-youtube that referenced this issue Jul 23, 2023
@elibarzilay
Add an aspectratio attribute
8e56879 
Makes it possible to handle non-16/9 videos, and fixes justinribeiro#92.
@elibarzilay elibarzilay mentioned this issue Jul 23, 2023
Closed
@elibarzilay elibarzilay changed the title Fixed aspect ratio doesn't work when ... it's different Doesn't work well when aspect ratio is different from 16:9 Jul 23, 2023
elibarzilay added a commit to elibarzilay/lite-youtube that referenced this issue Jul 28, 2023
@elibarzilay
Add an aspectratio attribute
2271641 
Makes it possible to handle non-16/9 videos, and fixes justinribeiro#92.
@elibarzilay elibarzilay mentioned this issue Jul 28, 2023
Closed
@justinribeiro justinribeiro mentioned this issue Nov 14, 2024
Merged
@justinribeiro justinribeiro added this to the v1.6.0 milestone Nov 14, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.0
2 participants
@elibarzilay @justinribeiro