fix: dump support symbol (close: #77) #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For easy to use, I think should provide utils function dump any object from qjs and export any object to qjs |
justjake
requested changes
Dec 14, 2022
ts/context.ts
Outdated
| @@ -738,6 +738,9 @@ export class QuickJSContext implements LowLevelJavascriptVm<QuickJSHandle>, Disp | |||
| return this.getNumber(handle) | |||
| } else if (type === "undefined") { | |||
| return undefined | |||
| } else if (type === "symbol") { | |||
| const desc = this.getString(this.getProp(handle, "description")) | |||
There was a problem hiding this comment.
I think the property handle is leaked. It needs to be disposed.
There was a problem hiding this comment.
Fix by this?
const propHd = this.getProp(handle, "description")
const desc = this.getString(propHd)
propHd.dispose()
return Symbol(desc)
justjake
approved these changes
Feb 18, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.