Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix build for kernel 6.14 #119

Merged
merged 2 commits into from
Feb 24, 2025
Merged

fix build for kernel 6.14 #119

merged 2 commits into from
Feb 24, 2025

Conversation

amazingfate
Copy link

.get_tx_power is changed since 6.14: torvalds/linux@7a53af8

@Jookia
Copy link

Jookia commented Feb 17, 2025

Duplicate of #119 ? Maybe you meant to send lwfinger/rtl8723ds@4b8d758 as 119?

@amazingfate
Copy link
Author

Duplicate of #119 ? Maybe you meant to send lwfinger/rtl8723ds@4b8d758 as 119?

No, this fix is cause by change of .get_tx_power upstream since 6.14.

@Jookia
Copy link

Jookia commented Feb 17, 2025

The 6.13 patch already does that

@Jookia
Copy link

Jookia commented Feb 17, 2025

Oops, I mean #118

@amazingfate
Copy link
Author

Oops, I mean #118

Yes, this pr is doing the same thing. But commit torvalds/linux@7a53af8 is not in 6.13:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/include/net/cfg80211.h?h=linux-6.13.y.
It is introduced in 6.14-rc1.
I wonder why that pr is for 6.13.

@Jookia
Copy link

Jookia commented Feb 17, 2025

Hmm. Also just for note, rtl8189fs branch requires lwfinger/rtl8723ds@4b8d758 to build

@CGarces
Copy link
Collaborator

CGarces commented Feb 23, 2025

Hi!

Sorry for the delay I don't have free time to maintain this.

@amazingfate can you please rebase to get the last commit that fix the github action?

@amazingfate
Copy link
Author

Hi!

Sorry for the delay I don't have free time to maintain this.

@amazingfate can you please rebase to get the last commit that fix the github action?

Hi, this pr is for master branch and it is missing the github action fix.

@amazingfate
Copy link
Author

Now I have added a commit to fix the github action.

@CGarces
Copy link
Collaborator

CGarces commented Feb 24, 2025

@amazingfate opps, sorry for the confusion

@CGarces CGarces merged commit fcf2a57 into jwrdegoede:master Feb 24, 2025
9 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants