-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Updated ratatui to avoid mismatch (fixes #35) #36
Conversation
Additionally, I had to swap the multibyte checkmark icon with a single-byte checkmark icon since it was breaking tests. Also, it could break the UI since it's rendered differently on different systems Edit: even if the multibyte X was not breaking tests, it still might break the UI, so I swapped it also |
Thank you. I'll check and merge |
Pull Request Test Coverage Report for Build 9162133625Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@deepu105 I'm not sure why clippy is failing as I haven't touched Edit: Since clippy is failing not as a result of my changes, I added an attribute which makes clippy skip that one particular trait. It looks like AppResource should be ultimately removed though. |
Thank you @tolik518 , Any reason you changed the icons for tick and cross? now they are not that obvious |
Hey @deepu105, yes, they were multi byte characters, which means that they get rendered differently depending on which font, shell and or terminal you use. Edit: I guess the tests weren't failing before that because ratatui might have changed some behavior for multi byte characters? |
Ya seems like something changed at ratatui. I'll keep the ones you proposed for now |
This pr should fix #35.
The compile error in #35 is thrown due to a ratatui version mismatch. Some code had to be adjusted for the new version, but these were only minor changes
Also Im think its good to keep the libraries up to date :)