-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[#719] JSON-B extension. #720
Open
bmarwell
wants to merge
4
commits into
jwtk:master
Choose a base branch
from
bmarwell:719_jsonb_extension
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+427
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdemers
reviewed
Apr 18, 2022
bdemers
reviewed
Apr 18, 2022
bdemers
reviewed
Apr 18, 2022
extensions/jsonb/src/main/java/io/jsonwebtoken/jsonb/io/JsonbDeserializer.java
Outdated
Show resolved
Hide resolved
bdemers
reviewed
Apr 18, 2022
extensions/jsonb/src/main/java/io/jsonwebtoken/jsonb/io/JsonbSerializer.java
Outdated
Show resolved
Hide resolved
bdemers
reviewed
Apr 18, 2022
Great work! |
Oh, shouldn’t the profile name be "nonJDK7"? And did I, by accident, not rebase the PR? |
good point, java8plus, nonJDK7 or something like that would work |
Nah you already have "nonJDK7" in your root- |
22ec763
to
cb1f42e
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #719:
This commit will add a JSON-B extension based on JSON-B specification 1.0.2.
Noteworthy
jdk.version
was set to8
.null
input is validated byjava.util.Objcets.requireNonNull
and will throw aNullPointerException
(which makes more sense anyway) instead of anIllegalArgumentException
.Strings.UTF_8
the JDK8-includedStandardCharsets.UTF_8
was used.intergation-tests/json/jsonb-yasson
andintergation-tests/json/jsonb-sth-else
).provided
) dependency on json-api (aka json-p for JSON-Parser) is needed at least for Johnzon, but probably for some Exceptions as well. Johnzon fails becausejavax.json.JsonException
is missing. But since json-api/json-p is a transitive dependency for json-bind-api (json-b) as well, this should be okay.Other notes
provided
scope is because of JakarteEE Application Server usage. Tested on OpenLiberty. But for JavaSE apps, users of this lib would need to include those by hand, as well as the implementation. This should go into the README.Tasks