Fix some warnings and errors in modern Clang and libc++ #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lambda functions are no longer allowed to capture structured bindings (see [P0588R1, Change in 8.1.5.2 expr.prim.lambda.capture paragraph 8](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0588r1.html)). To work around this problem, make local copies of bindings where appropriate and refactor unicode::property_enum generation where that's helpful.
|
Thanks for looking at this. I'll try and take a look at them closer sometime later this week. |
ay0ks
approved these changes
Nov 11, 2022
|
Thanks for this. Sorry for exceptionally long wait. Decided to dust this nearly abandoned project off. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among the changes required to make lug compile with modern Clang and libc++, these are the most straightforward.