Add missing support for float64 and several other value types #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twz123
reviewed
Nov 12, 2024
kke
changed the title
kke
force-pushed
the
support-floats
branch
3 times, most recently
from
c4d2254 to
4cdefe3
Compare
Signed-off-by: Kimmo Lehto <kimmo.lehto@gmail.com> Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <kimmo.lehto@gmail.com> Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
They were converted to JSON to drop the dependency on a specific YAML decoder. Signed-off-by: Kimmo Lehto <kimmo.lehto@gmail.com> Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing float support was noticed in k0sproject/k0sctl#785
YAMLs could also contain
[]bytevia!!binary f00f00. Some other types liketime.Timeare possible but when decoding into a plain map, they will be strings.Fixes #5
Closes #4 (I totally missed a PR that was submitted to fix the same problem.)