Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove the unused file store in a temp folder #5101

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Oct 10, 2024

Description

The download works without it since efc3f72. Also: Rename oci.go to download.go. This is about downloading OCI artifacts, so it seems to be a more appropriate name.

These are some small cleanups as a follow-up to #5075.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

This is about downloading OCI artifacts, so it seems to be a more
appropriate name.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
The download works without it since efc3f72.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 added the chore label Oct 10, 2024
@twz123 twz123 requested a review from a team as a code owner October 10, 2024 06:56
@twz123 twz123 requested review from kke and jnummelin October 10, 2024 06:56
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@ricardomaraschini ricardomaraschini merged commit ef9c0c1 into k0sproject:main Oct 10, 2024
89 checks passed
@twz123 twz123 deleted the remove-temp-file-store branch October 10, 2024 09:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants