Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ADR 1: Some formatting nits #5109

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Oct 10, 2024

Description

  • Small whitespace and Markdown fixes
  • Move markdownlint config into its canonical place, so that it will be picked up by the usual tooling.
  • Use tabs in the example Go code

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added documentation Improvements or additions to documentation chore labels Oct 10, 2024
@twz123 twz123 requested review from a team as code owners October 10, 2024 14:18
@twz123 twz123 requested review from ncopa and makhov October 10, 2024 14:18
@twz123 twz123 removed the documentation Improvements or additions to documentation label Oct 10, 2024
@twz123 twz123 force-pushed the adr01-formatting-nits branch from 620c736 to 0dfa5ad Compare October 10, 2024 14:38
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
So that it will be picked up by the usual tooling.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@ricardomaraschini ricardomaraschini merged commit 66080bf into k0sproject:main Oct 11, 2024
92 checks passed
@twz123 twz123 deleted the adr01-formatting-nits branch November 14, 2024 11:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants