Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable BuildKit's InvalidDefaultArgInFrom build check #5374

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Dec 20, 2024

Description

The BUILDIMAGE argument has no default value by design, since it always comes from the Makefile. So disable the check.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

The BUILDIMAGE argument has no default value by design, since it always
comes from the Makefile. So disable the check.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 added the chore label Dec 20, 2024
@twz123 twz123 marked this pull request as ready for review December 20, 2024 14:59
@twz123 twz123 requested review from a team as code owners December 20, 2024 14:59
@twz123 twz123 requested review from ncopa and jnummelin December 20, 2024 14:59
@twz123 twz123 merged commit 3dc9bd4 into k0sproject:main Jan 7, 2025
90 checks passed
@twz123 twz123 deleted the disable-buildkit-check branch January 7, 2025 14:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants