Replace pid with flock for runtime config loading #5435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
|
Shouldn't we leave it as is and eventually remove the whole runtime config file instead? |
how do you mean? |
|
This pull request has merge conflicts that need to be resolved. |
ncopa
force-pushed
the
lock-config
branch
2 times, most recently
from
b58069c to
92be067
Compare
That appears to be a fairly intrusive change. This is a cheap and non-intrusive way to fix the specific problem at hand that easily can be backported. |
twz123
reviewed
Jan 16, 2025
|
This pull request has merge conflicts that need to be resolved. |
ncopa
force-pushed
the
lock-config
branch
4 times, most recently
from
58b09ae to
4b0f2f1
Compare
twz123
reviewed
Jan 19, 2025
ncopa
force-pushed
the
lock-config
branch
4 times, most recently
from
9a20f31 to
d5e2254
Compare
|
This pull request has merge conflicts that need to be resolved. |
Use lock file and flock(2) to ensure there is only a single instance of k0s running. This is more reliable than storing the pid in the runtime config. This solves false positives with k0s runtime config leftovers. Fixes: k0sproject#5399 Signed-off-by: Natanael Copa <ncopa@mirantis.com>
Since we removed the pid from runtime config we can no longer skip the is-k0s-running-test by letting the pid be zero. So we need to create a proper runtime lock file by using NewRuntimeConfig. Signed-off-by: Natanael Copa <ncopa@mirantis.com>
twz123
approved these changes
Jan 22, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use lock file and flock(2) to ensure there is only a single instance of k0s running. This is more reliable than storing the pid in the runtime config.
This also solves false positives with k0s runtime config leftovers.
Fixes: #5399
Description
Fixes #5399
Type of change
How Has This Been Tested?
Checklist: