Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Always treat an etcd backend as joinable #5437

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Always treat an etcd backend as joinable #5437

merged 1 commit into from
Jan 24, 2025

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jan 15, 2025 •
edited
Loading

Description

Controllers will always be able to connect to an etcd backend, either by joining as a managed etcd node, or by simply connecting to an external cluster over the network. Add some comments about whether a backend is considered joinable or not to both the etcd and kine storage types.

Fixes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 linked an issue Jan 15, 2025 that may be closed by this pull request
Document how to "join" controllers when external etcd is used #4311
Closed
@twz123 twz123 force-pushed the external-etcd-join branch from 82f48bd to c517889 Compare January 15, 2025 13:28
@twz123
Always treat an etcd backend as joinable
5d4e3dc 
Controllers will always be able to connect to an etcd backend, either by
joining as a managed etcd node, or by simply connecting to an external
cluster over the network. Add some comments about whether a backend is
considered joinable or not to both the etcd and kine storage types.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 force-pushed the external-etcd-join branch from c517889 to 5d4e3dc Compare January 15, 2025 14:39
@twz123 twz123 marked this pull request as ready for review January 16, 2025 13:25
@twz123 twz123 requested review from a team as code owners January 16, 2025 13:25
@twz123 twz123 requested review from ncopa and kke January 16, 2025 13:25
@twz123 twz123 added this to the 1.32 milestone Jan 20, 2025
juanluisvaladas
juanluisvaladas approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@juanluisvaladas juanluisvaladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to get this merged in 1.32.1.

@twz123 twz123 merged commit f3a2dcf into k0sproject:main Jan 24, 2025
93 checks passed
@twz123 twz123 deleted the external-etcd-join branch January 24, 2025 09:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@juanluisvaladas juanluisvaladas juanluisvaladas approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
area/controlplane component/etcd enhancement New feature or request
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.

Document how to "join" controllers when external etcd is used
2 participants
@twz123 @juanluisvaladas