Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Publish version in controlnode status #5508

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Publish version in controlnode status #5508

wants to merge 1 commit into from
+7 −2

Conversation

makhov
Copy link
Contributor

@makhov makhov commented Feb 4, 2025 •
edited
Loading

Description

Fixes #5500
Adding k0s version to the control node status. This lets us check the update progress using kube api

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@makhov makhov force-pushed the add-version-to-controlnode-status branch 3 times, most recently from ff4675b to 4933394 Compare February 17, 2025 09:36
@makhov makhov marked this pull request as ready for review February 17, 2025 10:04
@makhov makhov requested review from a team as code owners February 17, 2025 10:04
@makhov makhov requested review from ncopa and twz123 February 17, 2025 10:04
@apedriza apedriza mentioned this pull request Feb 18, 2025
Merged
twz123
twz123 reviewed Feb 24, 2025
View reviewed changes
pkg/apis/autopilot/v1beta2/types.go Outdated
@@ -37,6 +37,7 @@ type ControlNode struct {
// ControlNodeStatus has the runtime status info of the controller such as address etc.
type ControlNodeStatus struct {
Addresses []corev1.NodeAddress `json:"addresses,omitempty"`
Version string `json:"version,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about calling this k0sVersion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed it

@makhov
Publish version in controlnode status
d1b9f65 
Signed-off-by: amakhov <amakhov@mirantis.com>
@makhov makhov force-pushed the add-version-to-controlnode-status branch from 4933394 to d1b9f65 Compare February 27, 2025 08:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@twz123 twz123 twz123 left review comments

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autopilot ControllerNode needs version info in the status
2 participants
@makhov @twz123