Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Layout collapses when comment contains line breaks #32

Closed
iwa4 opened this issue Jul 9, 2018 · 3 comments
Closed

Layout collapses when comment contains line breaks #32

iwa4 opened this issue Jul 9, 2018 · 3 comments
Assignees
Labels
bug Something isn't working pull request wanted

Comments

@iwa4
Copy link

iwa4 commented Jul 9, 2018

テーブルのコメントに改行が含まれている場合、個々の md は問題ないですが README.md の表が崩れるようです。 markdown で出力するコメント部分が <br> 対応されると良いのかなと思いました。

  • sql
COMMENT ON TABLE schemaX.test_table IS 'title xxx.

Description xxx.';
  • schemaX.test_table.md
# schemaX.test_table

## Description

title xxx.

Description xxx.
  • README.md
## Tables

| Name | Columns | Comment | Type |
| ---- | ------- | ------- | ---- |
| [schemaX.test_table](schemaX.test_table.md) | 1 | title xxx.

Description xxx. | BASE TABLE |
@k1LoW k1LoW self-assigned this Jul 9, 2018
@k1LoW k1LoW added bug Something isn't working pull request wanted labels Jul 9, 2018
@k1LoW
Copy link
Owner

k1LoW commented Jul 9, 2018

@iwa4 Thank you for your report !!

k1LoW added a commit that referenced this issue Jul 9, 2018
@k1LoW k1LoW closed this as completed in #34 Jul 9, 2018
@iwa4
Copy link
Author

iwa4 commented Jul 13, 2018

@k1LoW ありがとうございます!
早速試してみたのですが README.md の方がまだ崩れるようです。私の descrption が曖昧でした 🙇
table row に改行が入っているからのようです。 (table column commnet は問題なかったです)

  • README.md (actual)
## Tables

| Name | Columns | Comment | Type |
| ---- | ------- | ------- | ---- |
| [schemaX.test_table](schemaX.test_table.md) | 1 | title xxx.
<br>
<br>Description xxx. | BASE TABLE |
  • README.md (expect)
## Tables

| Name | Columns | Comment | Type |
| ---- | ------- | ------- | ---- |
| [schemaX.test_table](schemaX.test_table.md) | 1 | title xxx.<br><br>Description xxx. | BASE TABLE |

@k1LoW k1LoW reopened this Jul 13, 2018
@k1LoW
Copy link
Owner

k1LoW commented Jul 13, 2018

@iwa4
Thank you for report !!!
tbls support LF \n .
Maybe, tbls should support LF \n AND CR \r (ex. Windows)

k1LoW added a commit that referenced this issue Jul 13, 2018
@k1LoW k1LoW closed this as completed in #35 Jul 13, 2018
k1LoW added a commit that referenced this issue Mar 9, 2019
k1LoW added a commit that referenced this issue Mar 9, 2019
k1LoW added a commit that referenced this issue Apr 25, 2019
k1LoW added a commit that referenced this issue Apr 25, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working pull request wanted
Projects
None yet
Development

No branches or pull requests

2 participants