Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BREAKING]Set path of temporary generated schema.json (instead of JSON string) to TBLS_SCHEMA #236

Merged
merged 3 commits into from
May 11, 2020

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented May 11, 2020

ARG_MAX limit was sometimes exceeded when large database schema was set as an environment variable

@k1LoW k1LoW self-assigned this May 11, 2020
@k1LoW k1LoW changed the title Set path of temporary generated schema.json (instead of JSON string) to TBLS_SCHEMA [BREAKING]Set path of temporary generated schema.json (instead of JSON string) to TBLS_SCHEMA May 11, 2020
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #236 into master will decrease coverage by 0.95%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   69.53%   68.58%   -0.96%     
==========================================
  Files          21       21              
  Lines        3585     3594       +9     
==========================================
- Hits         2493     2465      -28     
- Misses        856      897      +41     
+ Partials      236      232       -4     
Impacted Files Coverage Δ
datasource/datasource.go 22.31% <54.54%> (-12.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca403b5...baea496. Read the comment docs.

@k1LoW k1LoW merged commit 5bd1b81 into master May 11, 2020
@k1LoW k1LoW deleted the change-env-TBLS_SCHEMA-from-str-to-tmpfile branch May 11, 2020 08:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant