Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix detectVirtualRelations: default strategy #264

Merged
merged 3 commits into from
Nov 22, 2020

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Nov 22, 2020

If the relation already exists, do not create a new virtual relation.

@k1LoW k1LoW self-assigned this Nov 22, 2020
@k1LoW k1LoW force-pushed the fix-detect-virtual-relations-strategy branch from 8b96733 to fdb277b Compare November 22, 2020 14:12
@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #264 (d751b18) into master (670dc8a) will decrease coverage by 1.30%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   68.72%   67.42%   -1.31%     
==========================================
  Files          23       23              
  Lines        3831     3856      +25     
==========================================
- Hits         2633     2600      -33     
- Misses        940     1002      +62     
+ Partials      258      254       -4     
Impacted Files Coverage Δ
config/config.go 51.35% <0.00%> (-0.56%) ⬇️
schema/schema.go 29.10% <0.00%> (-4.04%) ⬇️
datasource/datasource.go 22.22% <0.00%> (-12.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2369817...d751b18. Read the comment docs.

@k1LoW k1LoW force-pushed the fix-detect-virtual-relations-strategy branch from 8670e72 to d751b18 Compare November 22, 2020 14:57
@k1LoW k1LoW merged commit 01271d5 into master Nov 22, 2020
@k1LoW k1LoW deleted the fix-detect-virtual-relations-strategy branch November 22, 2020 15:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant