Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update go-github-client version and and use new options in NewGithubClient. #572

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

kromiii
Copy link
Contributor

@kromiii kromiii commented Apr 13, 2024

I want to add GitHub App Authentication in AnalyzeGitHubContent function.

  • Upgrade go-github-client from v58.0.11 to v58.0.12, by which we can use factory.OwnerRepo function.
  • By using factory.OwnerRepo function, we can pass the option to NewGithubClient(). It will enable us to use GitHub App authentication in AnalyzeGitHubContent function.

My old PR (#571) failed CI, so I arranged it, and re-created the PR.

@k1LoW
Copy link
Owner

k1LoW commented Apr 13, 2024

@kromiii Thank you!

@k1LoW k1LoW merged commit 800f6be into k1LoW:main Apr 13, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Apr 13, 2024
@kromiii kromiii deleted the github-app-2 branch November 10, 2024 12:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants