Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix schema filter logic to prevent duplicated counts of tables #634

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

kromiii
Copy link
Contributor

@kromiii kromiii commented Nov 12, 2024

When I tested the schema filter function with a Distance of 3 in a very small schema for the development, I noticed the following error often occurs in filter.go:

Failed to load schema: failed to filter schema: failed to separate tables. expected: 10, actual: 16

By checking the function, I found a bug in the aggregation logic of the filter function, which caused duplicate tables to be counted in includes2, so I had fix it.

@k1LoW k1LoW added the bug Something isn't working label Nov 15, 2024
@k1LoW
Copy link
Owner

k1LoW commented Nov 15, 2024

@kromiii Thank you!

@k1LoW k1LoW merged commit 842be06 into k1LoW:main Nov 15, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Nov 15, 2024
@kromiii kromiii deleted the bugfix/prevent-duplicate-tables branch November 16, 2024 06:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants