-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[FEATURE] docker context support #601
Conversation
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Hi @developer-guy , I really don't know why I didn't look into this again so far, sorry! |
99490ca
to
4132757
Compare
Fixed the conflicts and merged it manually. Thanks for your contribution @developer-guy ! |
Unfortunately, this breaks when using a non-tcp docker context (e.g. SSH). 🤔 UPDATE: came up with this PR #674, but couldn't test it with TLS secured docker endpoint. Can you give this a try please @developer-guy ? |
Hey @iwilltry42
Currently k3d returns this
|
Hi @jawabuu , I'm currently testing with #674 (follow-up PR for this), so results might differ slightly.
The only thing I didn't test successfully yet is a TLS protected daemon process. UPDATE 1: now also tested with TLS (via context) 👍 |
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
What
I realized that when we work with different Docker Daemons running on remote hosts by using the Docker Context feature, k3d couldn't get corresponding Docker Daemon information properly.
Why
I tried the same demo with the KinD tool, and because it is using docker with an exec call, it works well with different Docker Contexts. So k3d should also be working too.
This PR fixes #593.
Implications
This PR comes with a lot of updates within the vendor directory.