Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[FEATURE] Expand environment variables in the config file #643

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

iwilltry42
Copy link
Member

@iwilltry42 iwilltry42 commented Jun 24, 2021

E.g. $HOME -> /home/iwilltry42
This is done unconditionally/unchecked and even before viper reads in the config and before the file gets validated using the JSONSchema.
That way, we don't have to include much logic and the user has the most freedom possible here.

Fixes #537

@iwilltry42 iwilltry42 added the enhancement New feature or request label Jun 24, 2021
@iwilltry42 iwilltry42 added this to the v5.0.0 milestone Jun 24, 2021
@iwilltry42 iwilltry42 self-assigned this Jun 24, 2021
@iwilltry42 iwilltry42 changed the base branch from main to main-v5 June 24, 2021 08:57
@iwilltry42 iwilltry42 force-pushed the feature/config-expand-env branch from d459319 to 98c6d6f Compare June 24, 2021 08:57
@iwilltry42 iwilltry42 merged commit 8e813ce into main-v5 Jun 24, 2021
@iwilltry42 iwilltry42 deleted the feature/config-expand-env branch June 24, 2021 09:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] supports variables expansion inside k3d config
1 participant