Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Enhancement/Fix] Properly use env/runtime info and inject dns accordingly #758

Merged
merged 7 commits into from
Sep 23, 2021

Conversation

iwilltry42
Copy link
Member

  • make use of environment and runtime info
  • DfD: use host.docker.internal
  • All other cases: use Docker network Gateway
  • k3d-tools: based on alpine to have getent present

@iwilltry42 iwilltry42 added bug Something isn't working enhancement New feature or request runtime Issue with the container runtime (docker) priority/high scope/package pkg/ labels Sep 23, 2021
@iwilltry42 iwilltry42 added this to the v5.0.0 milestone Sep 23, 2021
@iwilltry42 iwilltry42 self-assigned this Sep 23, 2021
@iwilltry42 iwilltry42 merged commit 55bdc47 into main-v5 Sep 23, 2021
@iwilltry42 iwilltry42 deleted the fix/dns-magic-macos branch September 23, 2021 10:31
iwilltry42 added a commit that referenced this pull request Sep 23, 2021
…ingly (#758)

- make use of environment and runtime info
- DfD: use host.docker.internal
- All other cases: use Docker network Gateway
- k3d-tools: based on alpine to have `getent` present
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working enhancement New feature or request priority/high runtime Issue with the container runtime (docker) scope/package pkg/
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant