Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] more resilient post-create cluster preparation (DNS) #780

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

iwilltry42
Copy link
Member

  • add retries to CoreDNS patch process (with 1 second wait times), as it may take some time for everything to be ready for this
    • new debug env flag: K3D_DEBUG_COREDNS_RETRIES=3 to specify number of tries to the CoreDNS patch process
  • cover all post-create preparation steps (currently: /etc/hosts & coredns for host.k3d.internal and coredns for network members) in a errgroup to run them concurrently

@iwilltry42 iwilltry42 added this to the v5.0.1 milestone Oct 10, 2021
@iwilltry42 iwilltry42 self-assigned this Oct 10, 2021
@iwilltry42 iwilltry42 force-pushed the feature/coredns-retry branch from 3558b19 to 4df00f6 Compare October 10, 2021 07:58
@iwilltry42 iwilltry42 force-pushed the feature/coredns-retry branch from 002a5af to 7805f32 Compare October 11, 2021 09:58
@iwilltry42 iwilltry42 merged commit 12180ff into main Oct 13, 2021
@iwilltry42 iwilltry42 deleted the feature/coredns-retry branch October 13, 2021 15:36
@marckhouzam
Copy link

@iwilltry42 FYI I was not able to start a cluster on my Mac with 5.0.1 (tried 5 times), but after setting export K3D_DEBUG_COREDNS_RETRIES=10 it worked. Maybe the default retry count should be increased?

@iwilltry42
Copy link
Member Author

@marckhouzam , v5.1.0 uses a different method to modify CoreDNS... does that work for you?

@marckhouzam
Copy link

@iwilltry42 with v5.1.0 I was able to create 5 clusters in a row without issue 🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants