Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Release-1.30] Fix secrets-encrypt reencrypt timeout error #11441

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

Backport #11385

Types of Changes

Verification

Testing

Linked Issues

#11438

User-Facing Change


Further Comments

* Add missing default OS for split server test

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Launch go routine and return for k3s secrets-encrypt reencrypt

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner December 9, 2024 18:26
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.95%. Comparing base (00f9018) to head (c1dde0e).
Report is 1 commits behind head on release-1.30.

Files with missing lines Patch % Lines
pkg/server/secrets-encrypt.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.30   #11441      +/-   ##
================================================
- Coverage         46.53%   41.95%   -4.59%     
================================================
  Files               179      179              
  Lines             18729    18730       +1     
================================================
- Hits               8716     7858     -858     
- Misses             8667     9678    +1011     
+ Partials           1346     1194     -152     
Flag Coverage Δ
e2etests 33.98% <0.00%> (-7.96%) ⬇️
inttests 34.67% <0.00%> (-0.08%) ⬇️
unittests 13.73% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 7466930 into k3s-io:release-1.30 Dec 9, 2024
30 checks passed
@dereknola dereknola deleted the reencrypt_timeout_1.30 branch December 16, 2024 18:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants