Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove experimental from embedded-registry flag #11443

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

  • Move Spegel (embedded-registry) to GA status in CLI. Docs will be update according to note it went GA in December 2024 releases.

Types of Changes

CLI

Verification

k3s server --help shows embedded-registry no longer has the experimental tag

Testing

Linked Issues

TBD

User-Facing Change


Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.62%. Comparing base (e9cf3a7) to head (4ecd4fa).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (e9cf3a7) and HEAD (4ecd4fa). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (e9cf3a7) HEAD (4ecd4fa)
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11443      +/-   ##
==========================================
- Coverage   47.66%   42.62%   -5.04%     
==========================================
  Files         181      181              
  Lines       18797    18797              
==========================================
- Hits         8960     8013     -947     
- Misses       8490     9583    +1093     
+ Partials     1347     1201     -146     
Flag Coverage Δ
e2etests 34.83% <ø> (-7.98%) ⬇️
inttests 18.72% <ø> (-16.10%) ⬇️
unittests 14.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 69c310d into k3s-io:master Dec 10, 2024
38 checks passed
@dereknola dereknola deleted the ga_spegel branch December 16, 2024 18:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants