Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate E2E tests to Docker Tests #11776

Merged
merged 9 commits into from
Feb 12, 2025
Merged

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Feb 12, 2025

Proposed Changes

  • Converted: Token, Secrets Encryption, and Autoimport E2E tests to new Docker Test framework
  • Run newly converted tests in GHA matrix
  • Converted last of the old docker tests, hardened, into new docker test framework
  • Removed old docker test files
  • Exclude several docker tests from arm64 runs. Runners are too flaky at the moment for certain tests.
  • Add missing Context ginkgo levels to several E2E tests

Types of Changes

Testing/CI

Verification

New CI is Green

Performance

Test E2E Docker
autoimport 7m 1s 2m 18s
secrets encryption 6m 11s 5m 46s
token N/A 4m 1s

Token was never run on PR CI, only nightly

Testing

Its testing all the way down

Linked Issues

#11775
#11420

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner February 12, 2025 17:56
Signed-off-by: Derek Nola <derek.nola@suse.com>
Remove E2E token test

Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Simplify DockerNode structs
Remove autoimport from E2E
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Remove secrets encryption E2E from Drone

Signed-off-by: Derek Nola <derek.nola@suse.com>
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.09%. Comparing base (45dbc43) to head (8f5bbc4).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11776      +/-   ##
==========================================
- Coverage   47.66%   44.09%   -3.58%     
==========================================
  Files         206      206              
  Lines       19519    19519              
==========================================
- Hits         9304     8606     -698     
- Misses       8874     9671     +797     
+ Partials     1341     1242      -99     
Flag Coverage Δ
e2etests 35.55% <ø> (-8.60%) ⬇️
inttests 35.07% <ø> (?)
unittests 16.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants