Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add netfilter statistic module to check-config #11860

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

anders-larsson
Copy link
Contributor

@anders-larsson anders-larsson commented Feb 28, 2025

Proposed Changes

Add CONFIG_NETFILTER_XT_MATCH_STATISTIC to check-config script as discussed on rancher slack.

E0227 20:36:41.752351  411079 proxier.go:1564] "Failed to execute iptables-restore" err=<
        exit status 1: Ignoring deprecated --wait-interval option.
        Warning: Extension statistic revision 0 not supported, missing kernel module?
        iptables-restore: line 86 failed
 >

Types of Changes

Bug fix

Verification

Ran the modified code on both a system with and without the kernel module added.

With:

- CONFIG_NETFILTER_XT_MATCH_STATISTIC: enabled (as module)

Without:

- CONFIG_NETFILTER_XT_MATCH_STATISTIC: missing (fail)

Testing

As far as I know it is not covered by any tests.

Linked Issues

User-Facing Change

NONE

Further Comments

Signed-off-by: Anders Larsson <anders.git@larsson.xyz>
@anders-larsson anders-larsson requested a review from a team as a code owner February 28, 2025 08:46
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.90%. Comparing base (1c6dc31) to head (d5e0d07).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11860      +/-   ##
==========================================
- Coverage   47.50%   44.90%   -2.60%     
==========================================
  Files         190      190              
  Lines       19094    19094              
==========================================
- Hits         9070     8574     -496     
- Misses       8722     9277     +555     
+ Partials     1302     1243      -59     
Flag Coverage Δ
e2etests 35.83% <ø> (-5.54%) ⬇️
inttests 35.23% <ø> (-0.14%) ⬇️
unittests 16.80% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants