Skip to content

Commit

Permalink
Fix default ports for dns:// scheme (#2)
Browse files Browse the repository at this point in the history
According to [values.yaml](https://github.com/coredns/helm/blob/master/stable/coredns/values.yaml#L130)
dns:// is supposed to be udp only with optional tcp enablement through
use_tcp flag.

Signed-off-by: Dinar Valeev <k0da@opensuse.org>
  • Loading branch information
k0da authored Apr 26, 2021
1 parent 5a2cf9e commit 77fc3bd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion stable/coredns/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: coredns
version: 1.15.1
version: 1.15.2
appVersion: 1.8.0
home: https://coredns.io
icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png
Expand Down
3 changes: 1 addition & 2 deletions stable/coredns/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,9 @@ Generate the list of ports automatically from the server definitions
{{- end -}}
{{- end -}}

{{/* If none of the zones specify scheme, default to dns:// on both tcp & udp */}}
{{/* If none of the zones specify scheme, default to dns:// udp */}}
{{- if and (not (index $innerdict "istcp")) (not (index $innerdict "isudp")) -}}
{{- $innerdict := set $innerdict "isudp" true -}}
{{- $innerdict := set $innerdict "istcp" true -}}
{{- end -}}

{{/* Write the dict back into the outer dict */}}
Expand Down

0 comments on commit 77fc3bd

Please # to comment.