Allow configuration of extra coredns server blocks #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abaguas
requested review from
donovanmuller,
k0da,
kuritka,
ytsarev and
jkremser
as code owners
abaguas
force-pushed
the
extracoredns/config
branch
from
0046059 to
8df9bc4
Compare
The goal of this PR is to allow configuration of the glue records of the other clusters in k8gb's coreDNS.
I know this defies DNS best practices because k8gb is not authoritative for the parent zone. However, it allows k8gb to do cluster discovery without depending on any infrastructure outside of the cluster.
The configuration is quite generic, giving the users freedom to configure what they desire, therefore we could add it to the chart.
Example configuration:
```
extraServerBlocks: |
example.com:5353 {
errors
health
ready
prometheus 0.0.0.0:9153
forward . /etc/resolv.conf
k8s_crd {
filter k8gb.absa.oss/dnstype=glue
negttl {{ .Values.k8gb.dnsZoneNegTTL }}
loadbalance weight
}
}
```
Testing:
```
helm package . && helm template k8gb k8gb-v0.13.0.tgz > manifests.yaml
```
Signed-off-by: abaguas <andre.aguas@protonmail.com>
abaguas
force-pushed
the
extracoredns/config
branch
from
8df9bc4 to
024d375
Compare
ytsarev
reviewed
Aug 29, 2024
ytsarev
approved these changes
Sep 17, 2024
|
Thanks. I will revise my usecase and document it if I still find the setup useful |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to allow configuration of the glue records of the other clusters in k8gb's coreDNS. I know this defies DNS best practices because k8gb is not authoritative for the parent zone. However, it allows k8gb to do cluster discovery without depending on any infrastructure outside of the cluster.
The configuration is quite generic, giving the users freedom to configure what they desire, therefore we could add it to the chart.
Example configuration:
Testing: