Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch external-dns back to official upstream #1762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Oct 26, 2024

Fixes #1744

This one needs extensive testing with various edge DNS environments.

The initial local test with rfc2136 is successful.

..

HOW TO RUN CI ---

By default, all the checks will be run automatically. Furthermore, when changing website-related stuff, the preview will be generated by the netlify bot.

Heavy tests

Add the heavy-tests label on this PR if you want full-blown tests that include more than 2-cluster scenarios.

Debug tests

If the test suite is failing for you, you may want to try triggering Re-run all jobs (top right) with debug logging enabled. It will also make the print debug action more verbose.

@ytsarev ytsarev added the help wanted Extra attention is needed label Oct 26, 2024
@ytsarev ytsarev changed the title Switch extenral-dns back to official upstream Switch external-dns back to official upstream Oct 26, 2024
Fixes k8gb-io#1744

Signed-off-by: Yury Tsarev <yury@upbound.io>
@ytsarev ytsarev force-pushed the external-dns-upstream branch from 49dc278 to 150c3f8 Compare October 26, 2024 22:49
Copy link
Collaborator

@abaguas abaguas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented on slack: https://cloud-native.slack.com/archives/C021P656HGB/p1730555833483909?thread_ts=1729982761.336259&cid=C021P656HGB

Version 0.15.0 can't create NS records. ThenewRecordSet function would need to be adapted: https://github.com/kubernetes-sigs/external-dns/blob/master/provider/azure/azure.go#L339

This is the error that we see:

time="2024-11-02T13:52:30Z" level=info msg="Updating NS record named 'cloud' to 'gslb-ns-eu-cloud.k8gb.io;gslb-ns-us-cloud.k8gb.io' for Azure DNS zone 'k8gb.io'."
time="2024-11-02T13:52:30Z" level=error msg="Failed to update NS record named 'cloud' to 'gslb-ns-eu-cloud.k8gb.io;gslb-ns-us-cloud.k8gb.io' for DNS zone 'k8gb.io': unsupported record type 'NS'"

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to upstream external-dns
2 participants