Configuration weight RR (1/4) #900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #50 The weight (optional field) configuration goes into the GSLB strategy. This PR only aims to load and validate the weight configuration, which is specified in percentages. ```yaml strategy: type: roundRobin # Use a round robin load balancing strategy, when deciding which downstream clusters to route clients too weight: 20% ``` gslb.spec.strategy.weight is not allowed for failover and geoip strategies. If it is not specified in roundRobin, then it is not a weight RoundRobin but classic one. Signed-off-by: kuritka <kuritka@gmail.com> move RoundRobinStrategy, FailoverStrategy, GeoStrategy constants into depresolver package
kuritka
requested review from
donovanmuller,
k0da,
somaritane,
ytsarev and
jkremser
as code owners
kuritka
added a commit
that referenced
this pull request
Jun 8, 2022
After #900 is merged. Strategies are not validated. I am adding validation to the strategy type. Signed-off-by: kuritka <kuritka@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #50
The weight (optional field) configuration goes into the GSLB strategy. This PR only aims
to load and validate the weight configuration, which is specified in percentages.
gslb.spec.strategy.weight is not allowed for failover and geoip strategies. If it is not specified in roundRobin,
then it is not a weight RoundRobin but classic one.
Signed-off-by: kuritka kuritka@gmail.com
move RoundRobinStrategy, FailoverStrategy, GeoStrategy constants into depresolver package