Add unmarshalling to Percentage #924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane,
ytsarev and
jkremser
as code owners
kuritka
force-pushed
the
wrr-crd
branch
4 times, most recently
from
1862eff to
f21d9d5
Compare
if we do `kubectl apply -f ...` with GSLB having:
```yaml
# valid values in glsb roundrobin
weight:
eu: 50%
us: 50
```
the JSON masrshaller doesn't know whether values are number (50) or string (50%, "50").
The value is `type Percentage string`. Unmrashal function makes conversion, so 50, 50%, "50","50%" are valid.
I made several changes:
- change comment in CRD
- Unmarshall
- Fix one of the unit-tests
- Regenerate Mocks
Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
changed the title
jkremser
requested changes
Jul 22, 2022
|
/close #50 discussion |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if we do
kubectl apply -f ...with GSLB having:the JSON masrshaller doesn't know whether values are number (50) or string (50%, "50").
The value is
type Percentage string. Unmrashal function makes conversion, so 50, 50%, "50","50%" are valid.I made several changes: