Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: error from events for STS analyzer #1256

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

naveenthangaraj03
Copy link
Contributor

@naveenthangaraj03 naveenthangaraj03 commented Sep 20, 2024

Closes #

📑 Description

  • Need to get the error from event for statefulset analyzer, previously it doesn't get the clear error from this analyzer, in the below image there are two statefulset with 0/3 and 0/1 but it doesn't get the error.
    Screenshot 2024-09-18 124356

  • After getting the error from event for statefulset and if there is no event then it will check the pod is in running state or not
    Screenshot 2024-09-19 165409

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com>
@naveenthangaraj03 naveenthangaraj03 requested review from a team as code owners September 20, 2024 10:50
@naveenthangaraj03 naveenthangaraj03 changed the title error from events for sts analyzer feat: error from events for STS analyzer Sep 20, 2024
Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com>
Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need someone to test this but the code looks good @k8sgpt-ai/k8sgpt-maintainers

@AlexsJones AlexsJones merged commit d8fad95 into k8sgpt-ai:main Oct 3, 2024
8 checks passed
AlexsJones pushed a commit that referenced this pull request Oct 24, 2024
* error from events for sts analyzer

Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com>

* Signedoff this commit

Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com>

---------

Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com>
Co-authored-by: Aris Boutselis <arisboutselis08@gmail.com>
Signed-off-by: AlexsJones <alexsimonjones@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants