Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix shell script finding #140

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Fix shell script finding #140

merged 1 commit into from
Oct 9, 2020

Conversation

MichalGuzieniuk
Copy link
Contributor

This PR fixes issues found by shellcheck in the bash script entrypoint.sh

  • SC2006: Use $(..) instead of legacy ...
  • SC2039: In POSIX sh, echo flags are not supported.
  • SC2086: Double quote to prevent globbing and word splitting.

ahalimx86
ahalimx86 approved these changes Sep 24, 2020
View reviewed changes
Copy link
Collaborator

@ahalimx86 ahalimx86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ahalimx86 ahalimx86 requested a review from zshi-redhat October 7, 2020 13:34
@zshi-redhat
Copy link
Collaborator

/lgtm

@ahalimx86 ahalimx86 merged commit c822350 into k8snetworkplumbingwg:master Oct 9, 2020
@MichalGuzieniuk MichalGuzieniuk deleted the fix/shellScripts branch May 17, 2021 15:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ahalimx86 ahalimx86 ahalimx86 approved these changes

@zshi-redhat zshi-redhat Awaiting requested review from zshi-redhat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichalGuzieniuk @zshi-redhat @ahalimx86