Fix wrong MAC address value in returned Result. #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
from the code i can see the problem and the fix |
adrianchiris
approved these changes
Nov 5, 2020
ahalimx86
reviewed
Nov 9, 2020
According to CNI Convention MAC address returned in the Result is the one configured by the plugin, but plugin return initial VF's MAC addr even if it was passed in cni config. MAC address value, returned by SetupVF function, assigned from the linkObj after mac address was setted. That's not correct, since linkObj don't point directly to underlying kernel's netlink object, so mac address still has initial value. Fix that by doing correct assignments. Fix: k8snetworkplumbingwg#143 Signed-off-by: Dmytro Linkin <dlinkin@nvidia.com>
DmytroLinkin
force-pushed
the
macaddr_fix
branch
from
feadd7f to
9526934
Compare
martinkennelly
approved these changes
Nov 10, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to CNI Convention MAC address returned in the Result is the
one configured by the plugin, but plugin return initial VF's MAC addr
even if it was passed in cni config.
MAC address value, returned by SetupVF function, assigned from the
linkObj after mac address was setted. That's not correct, since linkObj
don't point directly to underlying kernel's netlink object, so mac
address still has initial value.
Fix that by doing correct assignments.
Fix: #143
Signed-off-by: Dmytro Linkin dlinkin@nvidia.com