Avoid panicking in tests #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchSeba
reviewed
Apr 13, 2022
|
Yep |
|
/lgtm |
|
@adrianchiris PTAL |
|
@zeeke can you please have a look on the CI status? |
Using Gomega assertions makes test errors more readable. Upgrade GolangCI to v.1.45 to avoid errors like: "export data is newer version - update tool" Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
|
Yes, It seems to be related to an incompatibility between GolangCI 1.29 and Go 1.18 as GolangCI actions I encountered the same problem in #205 and I think it's not related to the code changes themselves. I fixed upgrading golangci to 1.49 |
SchSeba
approved these changes
Apr 26, 2022
e0ne
approved these changes
May 17, 2022
jingczhang
pushed a commit
to nokia/sriov-cni
that referenced
this pull request
Jul 7, 2022
Using Gomega assertions makes test errors more readable. Upgrade GolangCI to v.1.45 to avoid errors like: "export data is newer version - update tool" Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Gomega assertions makes test errors more readable in most cases.
Signed-off-by: Andrea Panattoni apanatto@redhat.com