Make sure the backup cleanup is always triggered #1033
Merged
+59
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kidswiss
requested review from
tobru and
lieneluksika
and removed request for
a team
Kidswiss
force-pushed
the
fix/cleanups_stuck
branch
2 times, most recently
from
2850ba2 to
0133ad2
Compare
This commit makes sure, that backups go into a completed state, even if there was nothing to backup at all. Signed-off-by: Simon Beck <simon.beck@vshn.ch>
Kidswiss
force-pushed
the
fix/cleanups_stuck
branch
from
0133ad2 to
be419e1
Compare
wejdross
approved these changes
Dec 11, 2024
TheBigLee
approved these changes
Dec 13, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit makes sure, that backups go into a completed state, even if there was nothing to backup at all.
This uncovered a series of race-conditions in the e2e-tests, which should now also be fixed.
Checklist
For Code changes
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog
area:operatorcharts/directory.