Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

why queryParams is undefined in server? #237

Closed
lfades opened this issue Jul 29, 2015 · 11 comments
Closed

why queryParams is undefined in server? #237

lfades opened this issue Jul 29, 2015 · 11 comments

Comments

@lfades
Copy link

lfades commented Jul 29, 2015

/blog?skip=10
FlowRouter.route('/blog', {
  subscriptions: function (params, queryParams) {
    console.log(queryParams) // --> client: {skip: 10} - server: undefined
  }
});

before I go to Kadira: flow-router everything worked fine

@arunoda
Copy link
Contributor

arunoda commented Jul 30, 2015

I hope this with FlowRouter SSR?

@arunoda
Copy link
Contributor

arunoda commented Jul 30, 2015

@arunoda arunoda added the bug label Jul 30, 2015
@abernix
Copy link

abernix commented Aug 4, 2015

This isn't just with SSR (although the bug you linked also exists). This happens if you have FastRender enabled on current version 2.0.1 of kadira:flow-router.

https://github.com/kadirahq/flow-router/blob/master/server/plugins/fast_render.js#L28

@arunoda
Copy link
Contributor

arunoda commented Aug 5, 2015

For that, I think we need a quick fix.
Will work on that.

On Tue, Aug 4, 2015 at 10:30 PM Jesse Rosenberger notifications@github.com
wrote:

This isn't just with SSR (although the bug you linked also exists). This
happens if you have FastRender enabled on current version 2.0.1 of
kadira:flow-router.

https://github.com/kadirahq/flow-router/blob/master/server/plugins/fast_render.js#L28


Reply to this email directly or view it on GitHub
#237 (comment)
.

@arunoda
Copy link
Contributor

arunoda commented Aug 5, 2015

Okay. I just fixed this and did a release: 2.0.2

@abernix
Copy link

abernix commented Aug 5, 2015

Awesome. Works great. Thanks for the quick-fix. Assuming you'll leave this open for SSR?

@arunoda
Copy link
Contributor

arunoda commented Aug 5, 2015

Yep.

On Wed, Aug 5, 2015 at 3:41 PM Jesse Rosenberger notifications@github.com
wrote:

Awesome. Works great. Thanks for the quick-fix. Assuming you'll leave this
open for SSR?


Reply to this email directly or view it on GitHub
#237 (comment)
.

@ashokgelal
Copy link

Has this been fixed for SSR? When using queryParams with ReactLayout, I get an "Invalid Checksum" warning. I did some digging and turned out params are not available on server.

@arunoda
Copy link
Contributor

arunoda commented Aug 18, 2015

It's not fixed yet. Will be soon. Within few days.
We are looking for a beta release for React soon.

@ashokgelal
Copy link

Any updates on this issue?

@arunoda
Copy link
Contributor

arunoda commented Sep 8, 2015

Check now. Published a new version: v3.3.0

@arunoda arunoda closed this as completed Sep 8, 2015
@arunoda arunoda removed the bug label Sep 8, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants