Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

notify_future needs to be resolved on the disconnect callback #103

Closed
bdraco opened this issue Sep 7, 2023 · 1 comment
Closed

notify_future needs to be resolved on the disconnect callback #103

bdraco opened this issue Sep 7, 2023 · 1 comment

Comments

@bdraco
Copy link
Contributor

bdraco commented Sep 7, 2023

bonaparte/src/bonaparte/device.py

Line 305 in 73280db

result = await future

The future should probably set an exception on disconnect so it doesn't block forever
kaechele added a commit that referenced this issue Sep 8, 2023
@kaechele
fix: resolve notify_future on disconnect (#103)
c0dff7f 
Signed-off-by: Felix Kaechele <felix@kaechele.ca>
@kaechele
Copy link
Owner

kaechele commented Sep 8, 2023

Thanks! That makes sense. I have pushed a possible fix to a branch that I'm going to test hopefully later today.

@bdraco bdraco closed this as completed Sep 8, 2023
kaechele added a commit that referenced this issue Sep 11, 2023
@kaechele
fix: resolve notify_future on disconnect (#103)
81ac894 
Signed-off-by: Felix Kaechele <felix@kaechele.ca>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaechele @bdraco