Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

FE: Do not refetch data on window focus #348

Closed
Haarolean opened this issue May 3, 2024 · 3 comments · Fixed by #380
Closed

FE: Do not refetch data on window focus #348

Haarolean opened this issue May 3, 2024 · 3 comments · Fixed by #380
Assignees
@masonwoodford
Labels
area/ux User experiense issues good first issue Up for grabs scope/frontend Related to frontend changes status/confirmed A bug that is a confirmed one. Applicable only for the bug label. status/triage/completed Automatic triage completed type/bug Something isn't working
Milestone
1.1

Comments

@Haarolean
Copy link
Member

Some components like ui/clusters/local/schemas/test/edit does refetch data via tsquery on window focus.
This is considered a harmful behavior, because if there are any unsaved changes made to the schema itself the data will be refetched and the changes would be lost.

TODO:

  1. Check all the places where window focus refetch is on but shouldn't be
  2. Add QUERY_REFETCH_OFF_OPTIONS in these places
@Haarolean Haarolean added good first issue Up for grabs scope/frontend Related to frontend changes type/bug Something isn't working status/confirmed A bug that is a confirmed one. Applicable only for the bug label. area/ux User experiense issues labels May 3, 2024
@kapybro kapybro bot added the status/triage Issues pending maintainers triage label May 3, 2024
@kapybro kapybro bot added status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels May 3, 2024
@Haarolean Haarolean moved this to Todo in Up for grabs May 3, 2024
@masonwoodford
Copy link
Contributor

Hey could I have this issue assigned to me please?

@masonwoodford
Copy link
Contributor

Just to clarify, how were you thinking of determining if "window focus refresh is on but shouldn't be". Should it just be disabled on components that have editable portions?

@Haarolean
Copy link
Member Author

Just to clarify, how were you thinking of determining if "window focus refresh is on but shouldn't be". Should it just be disabled on components that have editable portions?

yeah sounds like a good approach. And we could always adjust this in the future.

masonwoodford added a commit to masonwoodford/kafka-ui that referenced this issue May 11, 2024
@masonwoodford
fixes kafbat#348
6e724eb
@Haarolean Haarolean mentioned this issue May 11, 2024
Merged
13 tasks
masonwoodford added a commit to masonwoodford/kafka-ui that referenced this issue May 11, 2024
@masonwoodford
make query opts optional parameter (kafbat#348)
0151d93
masonwoodford added a commit to masonwoodford/kafka-ui that referenced this issue May 11, 2024
@masonwoodford
fix linting (kafbat#348)
8b563f1
@Haarolean Haarolean added this to the 1.1 milestone Jun 3, 2024
@Haarolean Haarolean moved this from Todo to PR Approved in Release 1.1 Jun 3, 2024
@Haarolean Haarolean moved this from Todo to PR Approved in Up for grabs Jun 3, 2024
@github-project-automation github-project-automation bot moved this from PR Approved to Done in Release 1.1 Sep 24, 2024
@github-project-automation github-project-automation bot moved this from PR Approved to Done in Up for grabs Sep 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@masonwoodford masonwoodford

Labels
area/ux User experiense issues good first issue Up for grabs scope/frontend Related to frontend changes status/confirmed A bug that is a confirmed one. Applicable only for the bug label. status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
Up for grabs
Status: Done
Release 1.1
Status: Done
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

FE: Fix refetching data on window focus masonwoodford/kafka-ui
2 participants
@Haarolean @masonwoodford