Update jaas.config for GCP managed Kafka (per Google docs) #1141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per GCP docs this is the correct JaasConfig:
https://cloud.google.com/managed-service-for-apache-kafka/docs/quickstart-java#configure_and_run_the_application
What changes did you make? (Give an overview)
Fixed the JaasConfig for GCP managed Kafka
Is there anything you'd like reviewers to focus on?
Yes Google doc states this:
If I got it correct "required" is already appended so I don't need to add it in this line, please confirm as I'm not to familiar with the code.
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
The generated config was failing and changing this line fixed it.
NOT WORKING:
WORKING:
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct