Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

UX: Topics: Set num of partitions to 1 by default #334

Merged
merged 1 commit into from
May 1, 2024

Conversation

LinusRichter
Copy link
Contributor

@LinusRichter LinusRichter commented May 1, 2024

What changes did you make? (Give an overview)

Fixes #329

I changed the default value of the "Number of Partitions"-field to 1.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@LinusRichter LinusRichter requested a review from a team as a code owner May 1, 2024 14:35
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels May 1, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi LinusRichter! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Haarolean Haarolean added scope/frontend Related to frontend changes type/bug Something isn't working area/ux User experiense issues area/topics and removed status/triage/manual Manual triage in progress labels May 1, 2024
@Haarolean Haarolean self-assigned this May 1, 2024
@Haarolean Haarolean changed the title closes kafbat/kafka-ui#329 UX: Topics: Set num of partitions to 1 by default May 1, 2024
@Haarolean Haarolean merged commit e91e70b into kafbat:main May 1, 2024
46 checks passed
@Haarolean
Copy link
Member

@LinusRichter Thanks for your first contribution to kafbat ui!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/topics area/ux User experiense issues scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: Create topic form is disabled with no obvious reason
2 participants